Create Entities in-memory from Autoentities#3129
Open
RubenCerna2079 wants to merge 23 commits intomainfrom
Open
Create Entities in-memory from Autoentities#3129RubenCerna2079 wants to merge 23 commits intomainfrom
RubenCerna2079 wants to merge 23 commits intomainfrom
Conversation
RubenCerna2079
force-pushed
the
dev/rubencerna/create-inmemory-entities-from-autoentities
branch
from
1972a8f to
2f256e4
Compare
RubenCerna2079
requested review from
Alekhya-Polavarapu,
aaronburtle,
anushakolan,
neeraj-sharma2592,
sourabh1007,
souvikghosh04 and
vadeveka
as code owners
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Aniruddh25
reviewed
Feb 20, 2026
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Aniruddh25
reviewed
Feb 20, 2026
Aniruddh25
reviewed
Feb 20, 2026
Aniruddh25
reviewed
Feb 20, 2026
Aniruddh25
reviewed
Feb 20, 2026
Aniruddh25
reviewed
Feb 20, 2026
Aniruddh25
reviewed
Feb 20, 2026
Aniruddh25
reviewed
Feb 20, 2026
| foreach ((string autoentityName, Autoentity autoentity) in autoentities) | ||
| { | ||
| int addedEntities = 0; | ||
| JsonArray? resultArray = await QueryAutoentitiesAsync(autoentity); |
Collaborator
There was a problem hiding this comment.
when querying, are we asking the right datasource to query from? How is that information being passed to QueryAutoentitiesAsync?
Aniruddh25
reviewed
Feb 20, 2026
Aniruddh25
reviewed
Feb 20, 2026
Aniruddh25
reviewed
Feb 20, 2026
| "stocks_view_selected": { | ||
| "source": { | ||
| "object": "stocks_view_selected", | ||
| "type": "view", |
Collaborator
There was a problem hiding this comment.
Can you also test by naming the child data sources explicitly? I dont know if we provide the datasource name in the sample files or rely on the default one.
Aniruddh25
reviewed
Feb 20, 2026
Aniruddh25
requested changes
Feb 20, 2026
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
Waiting on addressing some questions..
github-project-automation
bot
moved this from Todo
to Review In Progress
in Data API builder
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
We need to generate all the entities from the autoentities properties. In order to do this we need to use the query that was previously created and, add the newly generated entities into the runtime so the user can use them.
What is this change?
MsSqlMetadataProvider.cs: Finish creating theGenerateAutoentitiesIntoEntitiesfunction so that it uses the query to receive all of the tables and turn them into entities inside the runtimeConfig.RuntimeConfig.cs: Create new function that adds the new entities to the runtimeConfig. And also change the runtimeConfig to allow for theentitiesproperty to be missing if the user decides to use theautoentitiesproperty.How was this tested?